RFR: 8253050: jfr disassemble command processes --max-chunks incorrectly

[Ekaterina Vergizova]

Hi Erik,
thank you for the review.
Sorry for the inconvenience, could you please also approve my github PR for this fix?
https://github.com/openjdk/jdk/pull/205

Thanks,
Ekaterina

-----Original Message-----
From: Erik Gahlin <erik.gahlin at oracle.com> 
Sent: Friday, September 11, 2020 4:26 PM
To: Ekaterina Vergizova <katya at azul.com>
Cc: hotspot-jfr-dev at openjdk.java.net
Subject: Re: RFR: 8253050: jfr disassemble command processes --max-chunks incorrectly

Hello,

Looks good. Thanks for fixing this.

Erik

> On 11 Sep 2020, at 14:13, Ekaterina Vergizova <katya at azul.com> wrote:
> 
> Hello,
> 
> could I have a review of this fix.
> 
> JBS: https://bugs.openjdk.java.net/browse/JDK-8253050
> Webrev: https://cr.openjdk.java.net/~apetushkov/8253050/webrev.00/
> 
> The problem is caused by Disassemble.combineChunkSizes() implementation that checks maxChunks after incrementation of fileSize, therefore the first output file has extra chunk.
> 
> Testing:
> jdk/jdk/jfr/*
> 
> Thanks,
> Ekaterina
>