RFR: 8264633: Add missing logging to PlatformRecording#stop

Erik Gahlin egahlin at openjdk.java.net
Wed Apr 7 16:25:32 UTC 2021


On Fri, 2 Apr 2021 02:51:45 GMT, Denghui Dong <ddong at openjdk.org> wrote:

> small fix to add logging to the catch block in PlatformRecording#stop

src/jdk.jfr/share/classes/jdk/jfr/internal/PlatformRecording.java line 181:

> 179:                 Logger.log(LogTag.JFR, LogLevel.ERROR,
> 180:                            "Unable to complete I/O operation when dumping recording \"" + getName() + "\" (" + getId() + ") due to: "
> 181:                            + e.getMessage());

I think you can remove e.getMessage() part. It will not provide useful information in case of a problem, due to how tings are now implemented. Even if it would be changed, I think it is good to avoid printing  file paths when using the default log level.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3319


More information about the hotspot-jfr-dev mailing list