RFR: 8264633: Add missing logging to PlatformRecording#stop [v2]

Denghui Dong ddong at openjdk.java.net
Thu Apr 8 02:21:16 UTC 2021


On Wed, 7 Apr 2021 16:18:58 GMT, Erik Gahlin <egahlin at openjdk.org> wrote:

>> Denghui Dong has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   remove e.getMessage()
>
> src/jdk.jfr/share/classes/jdk/jfr/internal/PlatformRecording.java line 181:
> 
>> 179:                 Logger.log(LogTag.JFR, LogLevel.ERROR,
>> 180:                            "Unable to complete I/O operation when dumping recording \"" + getName() + "\" (" + getId() + ") due to: "
>> 181:                            + e.getMessage());
> 
> I think you can remove e.getMessage() part. It will not provide useful information in case of a problem, due to how tings are now implemented. Even if it would be changed, I think it is good to avoid printing  file paths when using the default log level.

removed.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3319


More information about the hotspot-jfr-dev mailing list