RFR: 8261441: JFR: Filename expansion [v9]

[Erik Gahlin]

On Mon, 26 Jul 2021 03:01:47 GMT, Denghui Dong <ddong at openjdk.org> wrote:

>> Hi,
>> Could I have a review of this change that let the users could use `%p` in the filename to represent the PID  when JFR.start/stop/dump.
>> 
>> ~~I haven't implemented `%t` described in the issue, because I don't think it's very useful.~~
>> 
>> Best,
>> Denghui Dong
>
> Denghui Dong has updated the pull request incrementally with one additional commit since the last revision:
> 
>   update man page

src/jdk.jfr/share/classes/jdk/jfr/internal/dcmd/AbstractDCmd.java line 195:

> 193: 
> 194:     protected final void print(String s, Object... args) {
> 195:         currentLine.append(args != null && args.length > 0 ? String.format(s, args) : s);

Why is args != null check needed?

(Fail fast may be preferable if something unexpected happens)

-------------

PR: https://git.openjdk.java.net/jdk/pull/4550