RFR: 8261441: JFR: Filename expansion [v9]

Denghui Dong ddong at openjdk.java.net
Thu Aug 5 02:22:31 UTC 2021


On Thu, 5 Aug 2021 00:28:25 GMT, Erik Gahlin <egahlin at openjdk.org> wrote:

>> Denghui Dong has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   update man page
>
> src/jdk.jfr/share/classes/jdk/jfr/internal/dcmd/AbstractDCmd.java line 195:
> 
>> 193: 
>> 194:     protected final void print(String s, Object... args) {
>> 195:         currentLine.append(args != null && args.length > 0 ? String.format(s, args) : s);
> 
> Why is args != null check needed?
> 
> (Fail fast may be preferable if something unexpected happens)

This check is not necessary(args is not null even if no any arg passes in), removed.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4550


More information about the hotspot-jfr-dev mailing list