[jdk17] RFR: 8266595: jdk/jfr/jcmd/TestJcmdDump.java with slowdebug bits fails with AttachNotSupportedException

[David Holmes]

On Wed, 30 Jun 2021 10:44:09 GMT, Erik Gahlin <egahlin at openjdk.org> wrote:

> Hi,
> 
> Could I have a review of a test fix that increases the timeout for attach. 
> 
> The test times out when running with slowdebug. I can reproduce the issue locally when running with the default 10 000 ms, but it works fine with 20 000 ms. I set the timeout to 50 000 ms, so attach at least have a chance to timeout, making it perhaps somewhat easier to analyze failures in the future (to rule timeout due to other reasons).
> 
> Thanks
> Erik

Hi Erik,

Not clear why you needed to do this the way you did. A query and a suggested change below.

Thanks,
David

test/jdk/jdk/jfr/jcmd/TestJcmdDump.java line 109:

> 107:             File recording = new File("TestJCMdDump.jfr");
> 108:             String[] params = buildParameters(pathToGCRoots, name, recording);
> 109:             OutputAnalyzer output = JcmdHelper.jcmd(params);

Not at all clear why you can't just add the additional timeout arg and still use the JcmdHelper ??

test/jdk/jdk/jfr/jcmd/TestJcmdDump.java line 118:

> 116:             System.out.println(output.getStderr());
> 117:             System.out.println("----------------------------------------");
> 118:             System.out.println();

You can just call `output.reportDiagnosticSummary()` to get this.

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.java.net/jdk17/pull/180