[jdk17] RFR: 8266595: jdk/jfr/jcmd/TestJcmdDump.java with slowdebug bits fails with AttachNotSupportedException

[Erik Gahlin]

On Mon, 5 Jul 2021 12:56:52 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Hi,
>> 
>> Could I have a review of a test fix that increases the timeout for attach. 
>> 
>> The test times out when running with slowdebug. I can reproduce the issue locally when running with the default 10 000 ms, but it works fine with 20 000 ms. I set the timeout to 50 000 ms, so attach at least have a chance to timeout, making it perhaps somewhat easier to analyze failures in the future (to rule timeout due to other reasons).
>> 
>> Thanks
>> Erik
>
> test/jdk/jdk/jfr/jcmd/TestJcmdDump.java line 109:
> 
>> 107:             File recording = new File("TestJCMdDump.jfr");
>> 108:             String[] params = buildParameters(pathToGCRoots, name, recording);
>> 109:             OutputAnalyzer output = JcmdHelper.jcmd(params);
> 
> Not at all clear why you can't just add the additional timeout arg and still use the JcmdHelper ??

I need to pass the the system property as the first argument. JcmdHelper uses the PidJcmdExecutor class in the test lib, which adds the PID as a first argument, so I would need to rewrite both JcmdHelper and PidJcmdExecutor to support system properties functionality, which seemed overkill for this single test case.

-------------

PR: https://git.openjdk.java.net/jdk17/pull/180