RFR: 8260589: Crash in JfrTraceIdLoadBarrier::load(_jclass*) [v2]

[Denghui Dong]

On Fri, 26 Feb 2021 15:31:06 GMT, Markus Grönlund <mgronlun at openjdk.org> wrote:

>> Hi Denghui,
>> 
>> I did not manage to find a solution that would could reduce verbosity, but i did find one, although a bit involved, that lets us keep it local to and integrated in the core of JFR itself.
>> 
>> Can you do a test run with this suggestion to see if it works for you?
>> 
>> Thanks
>> Markus
>
> Markus Grönlund has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - cds hook
>  - skip return value

src/hotspot/share/jfr/recorder/checkpoint/types/traceid/jfrTraceIdLoadBarrier.cpp line 99:

> 97:   assert(mirror != NULL, "invariant");
> 98:   const Klass* const k = java_lang_Class::as_Klass(mirror);
> 99:   return k != NULL ? load(k) : load_primitive(mirror);

I think the same modification should be made in JfrTraceId::load_raw.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2738