RFR: 8260589: Crash in JfrTraceIdLoadBarrier::load(_jclass*) [v2]

Markus Grönlund mgronlun at openjdk.java.net
Fri Mar 12 10:16:10 UTC 2021


On Mon, 1 Mar 2021 07:52:37 GMT, Denghui Dong <ddong at openjdk.org> wrote:

>> Markus Grönlund has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - cds hook
>>  - skip return value
>
> src/hotspot/share/jfr/recorder/checkpoint/types/traceid/jfrTraceIdLoadBarrier.cpp line 99:
> 
>> 97:   assert(mirror != NULL, "invariant");
>> 98:   const Klass* const k = java_lang_Class::as_Klass(mirror);
>> 99:   return k != NULL ? load(k) : load_primitive(mirror);
> 
> I think the same modification should be made in JfrTraceId::load_raw.

Thanks, Denghui, I will make the same change there. I will also put you down as a contributor to this change set.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2738


More information about the hotspot-jfr-dev mailing list