RFR: 8263725: JFR oldobject tests are not run when GCs are specified explicitly

Stefan Karlsson stefank at openjdk.java.net
Thu Mar 18 06:55:47 UTC 2021


On Wed, 17 Mar 2021 12:14:20 GMT, Markus Grönlund <mgronlun at openjdk.org> wrote:

>> The tests are tagged with @requires == "null", which has the effect that if you run with GC explicitly set, like:
>> make -C ../build/fastdebug test TEST=test/jdk/jdk/jfr/event/oldobject/TestZ.java JTREG="JAVA_OPTIONS=-XX:+UseG1GC"
>> 
>> then the tests won't run. The intention has probably been to only run the test with the default GC. I propose that we remove this and run the tests with other GCs as well. 
>> 
>> I've tested this locally with ZGC, G1, Parallel and Serial.
>> 
>> The following test doesn't work with ZGC and has been disabled for that GC:
>> test/jdk/jdk/jfr/event/oldobject/TestObjectDescription.java
>> 
>> The following test doesn't work with Serial and has been disabled for that GC
>> test/jdk/jdk/jfr/event/oldobject/TestClassLoaderLeak.java
>
> Looks good. Thanks.

Thanks for reviewing!

-------------

PR: https://git.openjdk.java.net/jdk/pull/3046


More information about the hotspot-jfr-dev mailing list