Integrated: 8263725: JFR oldobject tests are not run when GCs are specified explicitly

Stefan Karlsson stefank at openjdk.java.net
Thu Mar 18 06:55:49 UTC 2021


On Wed, 17 Mar 2021 11:05:07 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

> The tests are tagged with @requires == "null", which has the effect that if you run with GC explicitly set, like:
> make -C ../build/fastdebug test TEST=test/jdk/jdk/jfr/event/oldobject/TestZ.java JTREG="JAVA_OPTIONS=-XX:+UseG1GC"
> 
> then the tests won't run. The intention has probably been to only run the test with the default GC. I propose that we remove this and run the tests with other GCs as well. 
> 
> I've tested this locally with ZGC, G1, Parallel and Serial.
> 
> The following test doesn't work with ZGC and has been disabled for that GC:
> test/jdk/jdk/jfr/event/oldobject/TestObjectDescription.java
> 
> The following test doesn't work with Serial and has been disabled for that GC
> test/jdk/jdk/jfr/event/oldobject/TestClassLoaderLeak.java

This pull request has now been integrated.

Changeset: 72b82fd7
Author:    Stefan Karlsson <stefank at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/72b82fd7
Stats:     19 lines in 19 files changed: 0 ins; 14 del; 5 mod

8263725: JFR oldobject tests are not run when GCs are specified explicitly

Reviewed-by: tschatzl, mgronlun

-------------

PR: https://git.openjdk.java.net/jdk/pull/3046


More information about the hotspot-jfr-dev mailing list