RFR: 8275375: [REDO] JDK-8271949 dumppath in -XX:FlightRecorderOptions does not affect
Erik Gahlin
egahlin at openjdk.java.net
Tue Oct 19 12:00:53 UTC 2021
On Tue, 19 Oct 2021 07:07:24 GMT, Yasumasa Suenaga <ysuenaga at openjdk.org> wrote:
> I use `SecuritySupport::isWritable` because `SecuritySupport` does not have `canWrite` and we can use `isWritable` for this purpose.
OK
> We will throw IllegalArgumentException when IOException happens because IOE is check exception.
> DCmdConfigure would throw DCmdException when it catches IAE because I don't want to change method declaration (`setDumpPath()`).
>
Why not? It's better to throw a checked exception so any call to it, now or in the future, will have to deal with IO issues.
-------------
PR: https://git.openjdk.java.net/jdk/pull/6000
More information about the hotspot-jfr-dev
mailing list