RFR: 8275375: [REDO] JDK-8271949 dumppath in -XX:FlightRecorderOptions does not affect
Yasumasa Suenaga
ysuenaga at openjdk.java.net
Wed Oct 20 00:19:08 UTC 2021
On Tue, 19 Oct 2021 11:57:51 GMT, Erik Gahlin <egahlin at openjdk.org> wrote:
> Why not? It's better to throw a checked exception so any call to it, now or in the future, will have to deal with IO issues.
I thought it would be betteer if we don't change `setDumpPath()` decralation if possible. Ok, I added `throws IOException` to it in new commit.
I added try-catch statement around `setDumpPath(DEFAULT_DUMP_PATH)` as a result. You suggested to remove this, but I think it is better to leave because it is in `reset()`. This method does not have Javadoc, but it is nature that the developer guesses all of parameters in `Options` would be reset after this call. `dumppath` should be included of course.
-------------
PR: https://git.openjdk.java.net/jdk/pull/6000
More information about the hotspot-jfr-dev
mailing list