RFR: 8275375: [REDO] JDK-8271949 dumppath in -XX:FlightRecorderOptions does not affect

[Erik Gahlin]

On Wed, 20 Oct 2021 00:16:18 GMT, Yasumasa Suenaga <ysuenaga at openjdk.org> wrote:

> > Why not? It's better to throw a checked exception so any call to it, now or in the future, will have to deal with IO issues.
> 
> I thought it would be betteer if we don't change `setDumpPath()` decralation if possible. Ok, I added `throws IOException` to it in new commit. I added try-catch statement around `setDumpPath(DEFAULT_DUMP_PATH)` as a result. You suggested to remove this, but I think it is better to leave because it is in `reset()`. This method does not have Javadoc, but it is nature that the developer guesses all of parameters in `Options` would be reset after this call. `dumppath` should be included of course.

The reset() method is legacy and the contents could move into the static initializer (and setDumpPath() be removed), but it's outside the scope of this enhancement, so I'm fine with what you have.

I will try it out on other platforms in the next few days and get back to you with the final review.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6000