RFR: 8280684: JfrRecorderService failes with guarantee(num_written > 0) when no space left on device.

[David Holmes]

On Wed, 16 Feb 2022 12:41:52 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> I think JFR should report an error message and jvm should shut down safely instead of gurantee failure.
>> 
>> For instance, jdk.jfr.internal.Repository#newChunk() reports an appropriate message and stops jvm as below
>> by using JfrJavaSupport::abort().
>> 
>> [0.673s][error][jfr] Could not create chunk in repository /tmp/2022_01_12_22_32_42_18030, class java.io.IOException: Unable to create JFR repository directory using base location (/tmp)
>> [0.673s][error][jfr,system] Could not create chunk in repository /tmp/2022_01_12_22_32_42_18030, class java.io.IOException: Unable to create JFR repository directory using base location (/tmp)
>> [0.673s][error][jfr,system] An irrecoverable error in Jfr. Shutting down VM...
>> 
>> I modified StreamWriterHost not to call guarantee failure but to call JfrJavaSupport::abort().
>> I added a argument to JfrJavaSupport::abort() which tells os::abort() not to put out core 
>> because there is no space on device.
>> Could you please review the fix?
>
> test/hotspot/jtreg/runtime/jfr/TestJFRDiskFull.java line 28:
> 
>> 26:  * @test
>> 27:  * @bug 8280684
>> 28:  * @summary JfrRecorderService failes with guarantee(num_written > 0) when no space left on device.
> 
> typo: failes

Actually "summary" is meant to describe what the test does, not what the original bug was about

-------------

PR: https://git.openjdk.java.net/jdk/pull/7227