RFR: 8280684: JfrRecorderService failes with guarantee(num_written > 0) when no space left on device.

[Markus Grönlund]

On Wed, 26 Jan 2022 06:41:41 GMT, KIRIYAMA Takuya <duke at openjdk.java.net> wrote:

> I think JFR should report an error message and jvm should shut down safely instead of gurantee failure.
> 
> For instance, jdk.jfr.internal.Repository#newChunk() reports an appropriate message and stops jvm as below
> by using JfrJavaSupport::abort().
> 
> [0.673s][error][jfr] Could not create chunk in repository /tmp/2022_01_12_22_32_42_18030, class java.io.IOException: Unable to create JFR repository directory using base location (/tmp)
> [0.673s][error][jfr,system] Could not create chunk in repository /tmp/2022_01_12_22_32_42_18030, class java.io.IOException: Unable to create JFR repository directory using base location (/tmp)
> [0.673s][error][jfr,system] An irrecoverable error in Jfr. Shutting down VM...
> 
> I modified StreamWriterHost not to call guarantee failure but to call JfrJavaSupport::abort().
> I added a argument to JfrJavaSupport::abort() which tells os::abort() not to put out core 
> because there is no space on device.
> Could you please review the fix?

Takuya, can I suggest keeping your proposed changes but excluding the test?

-------------

PR: https://git.openjdk.java.net/jdk/pull/7227