[jdk18] RFR: 8278628: jdk/jfr/jmx/streaming/TestMaxSize.java Expected only one or two chunks

Erik Gahlin egahlin at openjdk.java.net
Mon Jan 17 08:35:50 UTC 2022


Hi,

Could I have review of a test fix. 

The test expects at most two chunks in the file repository. While it is true that RemoteRecordingStream::setMaxSize(1_000_000) will make sure there are not more than two known chunks, there can potentially be three files, which is what the test looks for. A file has to be completed before it becomes known to setMaxSize. 

Testing:  jdk/jfr/jmx/streaming/TestMaxSize

Thanks
Erik

-------------

Commit messages:
 - Initial

Changes: https://git.openjdk.java.net/jdk18/pull/105/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk18&pr=105&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8278628
  Stats: 26 lines in 1 file changed: 14 ins; 6 del; 6 mod
  Patch: https://git.openjdk.java.net/jdk18/pull/105.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk18 pull/105/head:pull/105

PR: https://git.openjdk.java.net/jdk18/pull/105


More information about the hotspot-jfr-dev mailing list