[jdk18] RFR: 8278628: jdk/jfr/jmx/streaming/TestMaxSize.java Expected only one or two chunks

Markus Grönlund mgronlun at openjdk.java.net
Tue Jan 18 14:51:32 UTC 2022


On Mon, 17 Jan 2022 01:20:37 GMT, Erik Gahlin <egahlin at openjdk.org> wrote:

> Hi,
> 
> Could I have review of a test fix. 
> 
> The test expects at most two chunks in the file repository. While it is true that RemoteRecordingStream::setMaxSize(1_000_000) will make sure there are not more than two known chunks, there can potentially be three files, which is what the test looks for. A file has to be completed before it becomes known to setMaxSize. 
> 
> Testing:  jdk/jfr/jmx/streaming/TestMaxSize
> 
> Thanks
> Erik

Marked as reviewed by mgronlun (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk18/pull/105


More information about the hotspot-jfr-dev mailing list