RFR: 8282420: JFR: Remove event handlers [v2]

Erik Gahlin egahlin at openjdk.java.net
Sat May 7 02:49:41 UTC 2022


On Thu, 5 May 2022 09:36:27 GMT, Jaroslav Bachorik <jbachorik at openjdk.org> wrote:

>> Erik Gahlin has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Cleanups
>
> src/jdk.jfr/share/classes/jdk/jfr/internal/PlatformEventType.java line 109:
> 
>> 107:             }
>> 108:         }
>> 109:         return 3;
> 
> Why is the default stack trace offset changed?

Previously the stack looked like this:

   UserEvent::commit() {
   UserEventHandler::write(startTime, duration ...);
   EventWriter::puStackTrace();
   JVM::getStackTraceId(4);

Now it looks like this:

   UserEvent::commit() {
   EventWriter::puStackTrace();
   JVM::getStackTraceId(3);
   
The branches isUsingConfiguration() and isExceptionEvent() are not affected because they used the EventHandler directly previously.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8383


More information about the hotspot-jfr-dev mailing list