RFR: 8282420: JFR: Remove event handlers [v2]
Erik Gahlin
egahlin at openjdk.java.net
Sat May 7 03:02:39 UTC 2022
On Thu, 5 May 2022 09:20:09 GMT, Jaroslav Bachorik <jbachorik at openjdk.org> wrote:
>> Erik Gahlin has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Cleanups
>
> src/jdk.jfr/share/classes/jdk/jfr/internal/EventInstrumentation.java line 139:
>
>> 137: this.settingInfos = buildSettingInfos(superClass, classNode);
>> 138: this.fieldInfos = buildFieldInfos(superClass, classNode);
>> 139: String n = annotationValue(classNode, ANNOTATION_TYPE_NAME.getDescriptor(), String.class);
>
> As well - the descriptor could be cached to avoid calling substring operations repeatedly.
Changed from Type to String in some places to reduce allocation. More could be done with the Method descriptor, but I didn't want to go overboard. If needed, I rather handle it separately.
-------------
PR: https://git.openjdk.java.net/jdk/pull/8383
More information about the hotspot-jfr-dev
mailing list