RFR: 8286647: JFR: Build failure when C1 or C2 is disabled after JDK-8282420

[Markus Grönlund]

On Thu, 12 May 2022 13:52:52 GMT, Jie Fu <jiefu at openjdk.org> wrote:

> Hi all,
> 
> JDK fails to build when c1 or c2 is disabled after JDK-8282420.
> The reason is that c1/c2 code is used without `#ifdef` guards.
> The fix just adds some `#ifdef`.
> 
> Testing:
>  - build   on Linux/x64
>  - jdk/jfr on Linux/x64
> 
> Thanks.
> Best regards,
> Jie

In general, we would like to reduce the amount of conditionalization because it makes the code harder to read and follow. Compilers should not require a definition until a definition is actually needed. Perhaps there are compilers out there that don't do this, but I can't think of any right now. If that is the case, we can revisit to add in the conditionals for them.

Please try to only conditionalize in jfrResolution.cpp if you can, thank you.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8680