RFR: 8286647: JFR: Build failure when C1 or C2 is disabled after JDK-8282420

Jie Fu jiefu at openjdk.java.net
Thu May 12 15:32:48 UTC 2022


On Thu, 12 May 2022 15:03:13 GMT, Markus Grönlund <mgronlun at openjdk.org> wrote:

> In general, we would like to reduce the amount of conditionalization because it makes the code harder to read and follow. Compilers should not require a definition until a definition is actually needed. Perhaps there are compilers out there that don't do this, but I can't think of any right now. If that is the case, we can revisit to add in the conditionals for them.
> 
> Please try to only conditionalize in jfrResolution.cpp if you can, thank you.

OK.

I revert changes in the `jfr.hpp`.
Not sure if it's fine for all the compilers.
But as you mentioned that we can add them back if it's really a problem.

The remaining change is necessary on Linux/x64.
Thanks.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8680


More information about the hotspot-jfr-dev mailing list