RFR: 8286668: JFR: Cleanup

Markus Grönlund mgronlun at openjdk.java.net
Fri May 13 14:33:48 UTC 2022


On Thu, 12 May 2022 19:35:43 GMT, Erik Gahlin <egahlin at openjdk.org> wrote:

> Could I have a review of some cleanups (remove unused imports, use record classes, change to switch expressions, remove unnecessary empty lines etc).
> 
> Most changes are self-explanatory, but the AbstractEventStream class may need a comment. It's changed so it no longer takes a recording object in the constructor. This means the recording object can be kept in a private field in the subclass EventDirectoryStream, which seems more appropriate as the object is not needed in the base class and its other subclass EventFileStream. A isRecording() method is added to describe if a stream is tied to an ongoing recording or not. The field parserState is made private, but exposed to subclasses using the parserState() method.
> 
> Testing: jdk/jdk/jfr
> 
> Thanks
> Erik

Marked as reviewed by mgronlun (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/8687


More information about the hotspot-jfr-dev mailing list