Integrated: 8286668: JFR: Cleanup
Erik Gahlin
egahlin at openjdk.java.net
Fri May 13 15:36:49 UTC 2022
On Thu, 12 May 2022 19:35:43 GMT, Erik Gahlin <egahlin at openjdk.org> wrote:
> Could I have a review of some cleanups (remove unused imports, use record classes, change to switch expressions, remove unnecessary empty lines etc).
>
> Most changes are self-explanatory, but the AbstractEventStream class may need a comment. It's changed so it no longer takes a recording object in the constructor. This means the recording object can be kept in a private field in the subclass EventDirectoryStream, which seems more appropriate as the object is not needed in the base class and its other subclass EventFileStream. A isRecording() method is added to describe if a stream is tied to an ongoing recording or not. The field parserState is made private, but exposed to subclasses using the parserState() method.
>
> Testing: jdk/jdk/jfr
>
> Thanks
> Erik
This pull request has now been integrated.
Changeset: 78ffefb8
Author: Erik Gahlin <egahlin at openjdk.org>
URL: https://git.openjdk.java.net/jdk/commit/78ffefb8492eb48a9bd964e7184830d4762e5adb
Stats: 228 lines in 27 files changed: 21 ins; 103 del; 104 mod
8286668: JFR: Cleanup
Reviewed-by: mgronlun
-------------
PR: https://git.openjdk.java.net/jdk/pull/8687
More information about the hotspot-jfr-dev
mailing list