RFR: 8287113: JFR: Periodic task thread uses period for method sampling events

Erik Gahlin egahlin at openjdk.java.net
Sat May 21 15:15:15 UTC 2022


Could I have a review that excludes the native method sampling event type from the JFR Periodic Task thread. Sampling is done in native code, not in the periodic task thread. 

The method sampling event (jdk.ExecutionSample) was already excluded, but jdk.NativeMethodSample was missing. This lead to the periodic task thread waking up 50 times per second instead of once (when using the default configuration). Each time the thread waits and an unnecessary JavaMonitorWait event was emitted.

Testing: jdk/jdk/jfr

-------------

Commit messages:
 - Initial

Changes: https://git.openjdk.java.net/jdk/pull/8824/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=8824&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8287113
  Stats: 5 lines in 2 files changed: 4 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/8824.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/8824/head:pull/8824

PR: https://git.openjdk.java.net/jdk/pull/8824


More information about the hotspot-jfr-dev mailing list