RFR: 8287113: JFR: Periodic task thread uses period for method sampling events

Jaroslav Bachorik jbachorik at openjdk.java.net
Mon May 23 07:08:00 UTC 2022


On Sat, 21 May 2022 14:22:52 GMT, Erik Gahlin <egahlin at openjdk.org> wrote:

> Could I have a review that excludes the native method sampling event type from the JFR Periodic Task thread. Sampling is done in native code, not in the periodic task thread. 
> 
> The method sampling event (jdk.ExecutionSample) was already excluded, but jdk.NativeMethodSample was missing. This lead to the periodic task thread waking up 50 times per second instead of once (when using the default configuration). Each time the thread waits an unnecessary JavaMonitorWait event was emitted.
> 
> Testing: jdk/jdk/jfr

Looks good!

-------------

Marked as reviewed by jbachorik (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/8824


More information about the hotspot-jfr-dev mailing list