RFR: 8297338: JFR: RemoteRecordingStream doesn't respect setMaxAge and setMaxSize [v4]

Erik Gahlin egahlin at openjdk.org
Wed Nov 23 13:02:39 UTC 2022


> Could I have a review of a PR  that fixes so event data is kept in the disk repository if max age or max size have been set. This is similar implementation as RecordingStream:
> https://github.com/openjdk/jdk/blob/b366d17a94e5b16710fd915ef4cf04aaf911b455/src/jdk.jfr/share/classes/jdk/jfr/consumer/RecordingStream.java#L287
> 
> I also fixed a problem where chunks may we written out of order in the dump file and disk chunks not being released properly in case of an IOException. To make the code easier to understand, the code uses more logical methods when interacting with the Deque , such as peekLast(), pollLast() and addFirst().
> 
> Testing: 100 * test/jdk/jdk/jfr/jmx/stream/TestRemoteDump.java + 1 * test/jdk/jdk/jfr/
> 
> Thanks
> Erik

Erik Gahlin has updated the pull request incrementally with one additional commit since the last revision:

  Improve test

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/11275/files
  - new: https://git.openjdk.org/jdk/pull/11275/files/226f30c7..371bc5ac

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=11275&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=11275&range=02-03

  Stats: 3 lines in 1 file changed: 3 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/11275.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/11275/head:pull/11275

PR: https://git.openjdk.org/jdk/pull/11275


More information about the hotspot-jfr-dev mailing list