RFR: 8297338: JFR: RemoteRecordingStream doesn't respect setMaxAge and setMaxSize [v4]

[Markus Grönlund]

On Wed, 23 Nov 2022 13:02:39 GMT, Erik Gahlin <egahlin at openjdk.org> wrote:

>> Could I have a review of a PR  that fixes so event data is kept in the disk repository if max age or max size have been set. This is similar implementation as RecordingStream:
>> https://github.com/openjdk/jdk/blob/b366d17a94e5b16710fd915ef4cf04aaf911b455/src/jdk.jfr/share/classes/jdk/jfr/consumer/RecordingStream.java#L287
>> 
>> I also fixed a problem where chunks may we written out of order in the dump file and disk chunks not being released properly in case of an IOException. To make the code easier to understand, the code uses more logical methods when interacting with the Deque , such as peekLast(), pollLast() and addFirst().
>> 
>> Testing: 100 * test/jdk/jdk/jfr/jmx/stream/TestRemoteDump.java + 1 * test/jdk/jdk/jfr/
>> 
>> Thanks
>> Erik
>
> Erik Gahlin has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Improve test

Marked as reviewed by mgronlun (Reviewer).

-------------

PR: https://git.openjdk.org/jdk/pull/11275