Integrated: 8297338: JFR: RemoteRecordingStream doesn't respect setMaxAge and setMaxSize
Erik Gahlin
egahlin at openjdk.org
Wed Nov 23 17:52:54 UTC 2022
On Mon, 21 Nov 2022 16:41:07 GMT, Erik Gahlin <egahlin at openjdk.org> wrote:
> Could I have a review of a PR that fixes so event data is kept in the disk repository if max age or max size have been set. This is similar implementation as RecordingStream:
> https://github.com/openjdk/jdk/blob/b366d17a94e5b16710fd915ef4cf04aaf911b455/src/jdk.jfr/share/classes/jdk/jfr/consumer/RecordingStream.java#L287
>
> I also fixed a problem where chunks may we written out of order in the dump file and disk chunks not being released properly in case of an IOException. To make the code easier to understand, the code uses more logical methods when interacting with the Deque , such as peekLast(), pollLast() and addFirst().
>
> Testing: 100 * test/jdk/jdk/jfr/jmx/stream/TestRemoteDump.java + 1 * test/jdk/jdk/jfr/
>
> Thanks
> Erik
This pull request has now been integrated.
Changeset: 2afb4c33
Author: Erik Gahlin <egahlin at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/2afb4c3327b6830a009ee1ab8a1eb7803ef53007
Stats: 247 lines in 5 files changed: 230 ins; 1 del; 16 mod
8297338: JFR: RemoteRecordingStream doesn't respect setMaxAge and setMaxSize
Reviewed-by: mgronlun
-------------
PR: https://git.openjdk.org/jdk/pull/11275
More information about the hotspot-jfr-dev
mailing list