RFR: 8291519: jdk/jfr/api/event/TestShouldCommit.java failed with Unexpected value of shouldCommit()

[Erik Gahlin]

Hi,

Could I have review of a test fix, which is a complete rewrite. 

Instead of verifying the clock, it checks the logic of the shouldCommit method. 

Testing: 100 * test/jdk/jdk/jfr/api/event/TestShouldCommit.java

Maybe there should be a test that checks that an event timestamp doesn't drift too much from the system clock, but I think there are better ways to check that than using the shouldCommit() method. 

Thanks
Erik

-------------

Commit messages:
 - Add asserts
 - Initial

Changes: https://git.openjdk.org/jdk/pull/10611/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=10611&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8291519
  Stats: 178 lines in 1 file changed: 54 ins; 53 del; 71 mod
  Patch: https://git.openjdk.org/jdk/pull/10611.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/10611/head:pull/10611

PR: https://git.openjdk.org/jdk/pull/10611