RFR: 8291519: jdk/jfr/api/event/TestShouldCommit.java failed with Unexpected value of shouldCommit()

[Markus Grönlund]

On Fri, 7 Oct 2022 17:41:10 GMT, Erik Gahlin <egahlin at openjdk.org> wrote:

> Hi,
> 
> Could I have review of a test fix, which is a complete rewrite. 
> 
> Instead of verifying the clock, it checks the logic of the shouldCommit method. 
> 
> Testing: 100 * test/jdk/jdk/jfr/api/event/TestShouldCommit.java
> 
> Maybe there should be a test that checks that an event timestamp doesn't drift too much from the system clock, but I think there are better ways to check that than using the shouldCommit() method. 
> 
> Thanks
> Erik

Nice!

-------------

Marked as reviewed by mgronlun (Reviewer).

PR: https://git.openjdk.org/jdk/pull/10611