RFR: JDK-8313251: Add NativeLibraryLoad event [v2]

[Matthias Baesken]

On Fri, 28 Jul 2023 13:04:21 GMT, Erik Gahlin <egahlin at openjdk.org> wrote:

>> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   add macro guards because the build errors in zero build
>
> src/hotspot/share/jfr/metadata/metadata.xml line 942:
> 
>> 940:   </Event>
>> 941: 
>> 942:   <Event name="NativeLibraryLoad" category="Java Virtual Machine, Runtime" label="Native Library Load Operation" thread="false" stackTrace="true" startTime="true"
> 
> I think "Native Library Load" is sufficient as an event label and "Success" for the success field.
> 
> I think "error" is sufficient for the error field. We could use "errorMessage", if you believe there are other error related information we may want to add in the future.
> 
> The "name" label could changed to "Name", similar to the NativeLibrary event,

Hi Erik, I will adjust. I will use errorMessage because on some platforms we have already coding to describe shared lib load error situations in more detail (see for example os_linux.cpp).

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15065#discussion_r1281727323