RFR: JDK-8313251: Add NativeLibraryLoad event [v2]

Matthias Baesken mbaesken at openjdk.org
Wed Aug 2 11:31:52 UTC 2023


On Fri, 28 Jul 2023 13:11:35 GMT, Erik Gahlin <egahlin at openjdk.org> wrote:

>> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   add macro guards because the build errors in zero build
>
> test/jdk/jdk/jfr/event/runtime/TestNativeLibraryLoadEvent.java line 51:
> 
>> 49: 
>> 50:     public static void main(String[] args) throws Throwable {
>> 51:         Recording recording = new Recording();
> 
> Use try-with-resources.

Hi Erik, this was taken from test/jdk/jdk/jfr/event/runtime/TestNativeLibrariesEvent.java , I do not see in main there a try with resources.  What do you want to put in the try block exactly ? The new Recording()  ?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15065#discussion_r1281774188


More information about the hotspot-jfr-dev mailing list