RFR: 8319072: JFR: Turn off events for JFR.view

Mon Dec 4 15:31:41 UTC 2023

On Sat, 2 Dec 2023 19:41:16 GMT, Erik Gahlin <egahlin at openjdk.org> wrote:

> Could I have a review of a change that disables events for the Attach thread when executing the diagnostic command JFR.view. The rationale is to avoid exception events etc. that create noise in the output making troubleshooting the application harder. I also removed an incorrect comment.
> 
> I'm not a fan of overrides that return boolean values, but it was hard to come up with something better without a large refactoring, or adding boilerplate code to the other diagnostic commands.
> 
> Testing: idk/jdk/jfr
> 
> 
> 
> 
> Thanks
> Erik

Marked as reviewed by mgronlun (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/16936#pullrequestreview-1762729715