Integrated: 8319072: JFR: Turn off events for JFR.view

Erik Gahlin egahlin at openjdk.org
Mon Dec 4 16:11:49 UTC 2023


On Sat, 2 Dec 2023 19:41:16 GMT, Erik Gahlin <egahlin at openjdk.org> wrote:

> Could I have a review of a change that disables events for the Attach thread when executing the diagnostic command JFR.view. The rationale is to avoid exception events etc. that create noise in the output making troubleshooting the application harder. I also removed an incorrect comment.
> 
> I'm not a fan of overrides that return boolean values, but it was hard to come up with something better without a large refactoring, or adding boilerplate code to the other diagnostic commands.
> 
> Testing: idk/jdk/jfr
> 
> 
> 
> 
> Thanks
> Erik

This pull request has now been integrated.

Changeset: d2c529cc
Author:    Erik Gahlin <egahlin at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/d2c529cc37f94a1ecd3b03fd91e3e08ee8ee75c9
Stats:     24 lines in 3 files changed: 23 ins; 1 del; 0 mod

8319072: JFR: Turn off events for JFR.view

Reviewed-by: mgronlun

-------------

PR: https://git.openjdk.org/jdk/pull/16936


More information about the hotspot-jfr-dev mailing list