RFR: 8211238: @Deprecated JFR event [v16]
Markus Grönlund
mgronlun at openjdk.org
Tue Dec 5 17:49:43 UTC 2023
On Tue, 5 Dec 2023 17:43:41 GMT, Jaroslav Bachorik <jbachorik at openjdk.org> wrote:
>> Markus Grönlund has updated the pull request incrementally with one additional commit since the last revision:
>>
>> update event description
>
> src/hotspot/share/jfr/support/jfrNativeLibraryLoadEvent.cpp line 37:
>
>> 35: if (_start_time != nullptr) {
>> 36: delete _start_time;
>> 37: }
>
> This should not be necessary. Delete should not fail on `nullptr`.
start_time is a JfrCHeapObj, which is an allocator that hooks allocations and deallocations. With a direct delete, it will account for the size of the object even though its null. It should probably be fixed in the allocator, but I needed this to get the accounting back on track.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16931#discussion_r1416064517
More information about the hotspot-jfr-dev
mailing list