RFR: 8211238: @Deprecated JFR event [v16]

[Jaroslav Bachorik]

On Tue, 5 Dec 2023 17:46:58 GMT, Markus Grönlund <mgronlun at openjdk.org> wrote:

>> src/hotspot/share/jfr/support/jfrNativeLibraryLoadEvent.cpp line 37:
>> 
>>> 35:   if (_start_time != nullptr) {
>>> 36:     delete _start_time;
>>> 37:   }
>> 
>> This should not be necessary. Delete should not fail on `nullptr`.
>
> start_time is a JfrCHeapObj, which is an allocator that hooks allocations and deallocations. With a direct delete, it will account for the size of the object even though its null. It should probably be fixed in the allocator, but I needed this to get the accounting back on track.

Thanks for the explanation. I got a bit confused ...

>> src/jdk.jfr/share/classes/jdk/jfr/internal/test/DeprecatedMethods.java line 25:
>> 
>>> 23: package jdk.jfr.internal.test;
>>> 24: 
>>> 25: public class DeprecatedMethods {
>> 
>> Is this class (and also `DeprecatedThing`) supposed to be in the source tree rather than the test tree?
>
> They have to go into the source tree because we only report deprecated methods located in the JDK :)

Uff, magic :)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16931#discussion_r1416089579
PR Review Comment: https://git.openjdk.org/jdk/pull/16931#discussion_r1416088493