RFR: 8310661: JFR: Replace JVM.getJVM() with JVM

Markus Grönlund mgronlun at openjdk.org
Mon Jul 3 12:00:55 UTC 2023


On Thu, 29 Jun 2023 14:57:15 GMT, Erik Gahlin <egahlin at openjdk.org> wrote:

> Could I have a review of a change that makes instance methods in the JVM class static. 
> 
> Today some methods are static, others are not, which means the JVM object needs to be stored and passed around. A singleton object may have made sense in JDK 8 so JVM::getJVM() could be made caller sensitive, similar to Unsafe::getUnsafe(), but not anymore. The jdk.jfr.internal package is protected by the module system. 
> 
> Testing: jdk/jdk/jfr tier1 + tier2
> 
> Thanks
> Erik

Marked as reviewed by mgronlun (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/14713#pullrequestreview-1511045370


More information about the hotspot-jfr-dev mailing list