Integrated: 8310661: JFR: Replace JVM.getJVM() with JVM

Erik Gahlin egahlin at openjdk.org
Mon Jul 3 12:24:07 UTC 2023


On Thu, 29 Jun 2023 14:57:15 GMT, Erik Gahlin <egahlin at openjdk.org> wrote:

> Could I have a review of a change that makes instance methods in the JVM class static. 
> 
> Today some methods are static, others are not, which means the JVM object needs to be stored and passed around. A singleton object may have made sense in JDK 8 so JVM::getJVM() could be made caller sensitive, similar to Unsafe::getUnsafe(), but not anymore. The jdk.jfr.internal package is protected by the module system. 
> 
> Testing: jdk/jdk/jfr tier1 + tier2
> 
> Thanks
> Erik

This pull request has now been integrated.

Changeset: ba974d5c
Author:    Erik Gahlin <egahlin at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/ba974d5c62c332905b0466b704411a829d6c9ee3
Stats:     406 lines in 36 files changed: 25 ins; 72 del; 309 mod

8310661: JFR: Replace JVM.getJVM() with JVM

Reviewed-by: mgronlun

-------------

PR: https://git.openjdk.org/jdk/pull/14713


More information about the hotspot-jfr-dev mailing list