RFR: 8313141: Missing check for os_thread type in os_windows.cpp [v2]

David Holmes dholmes at openjdk.org
Sat Jul 29 05:55:02 UTC 2023


On Sat, 29 Jul 2023 05:50:18 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> os::os_thread is not handled in os_windows.cpp, and therefore ignores the thread stack size option. I am unsure if this is the right way to handle os::os_thread, please let me know if it is not
>
> Julian Waters has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Switch os::os_thread to default behaviour

src/hotspot/os/windows/os_windows.cpp line 721:

> 719:     case os::asynclog_thread:
> 720:     case os::watcher_thread:
> 721:     case os::os_thread:

How did you determine this is the correct behaviour for this type of thread? This will result in a change in behaviour.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15079#discussion_r1278255078


More information about the hotspot-jfr-dev mailing list