RFR: 8313141: Missing check for os_thread type in os_windows.cpp [v2]

[Markus Grönlund]

On Sat, 29 Jul 2023 05:55:02 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> os::os_thread is not handled in os_windows.cpp, and therefore ignores the thread stack size option. I am unsure if this is the right way to handle os::os_thread, please let me know if it is not
>
> Julian Waters has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Switch os::os_thread to default behaviour

It looks like the other platforms have a default case, instead of an explicit os_thread case, that considers VMThreadStackSize. For example, see os::Posix::get_initial_stack_size():

  default:  // presume the unknown thr_type is a VM internal


  product_pd(intx, VMThreadStackSize,
          "Non-Java Thread Stack Size (in Kbytes)")
          range(0, max_intx/(1 * K))


Align with how this is done for the *nix platforms?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15079#issuecomment-1658192633