RFR: 8303681: JFR: RemoteRecordingStream::setMaxAge() should accept null [v2]

Erik Gahlin egahlin at openjdk.org
Mon Mar 6 19:42:09 UTC 2023


> Could I have a review of a PR that removes a Objects.requireNonNull from the setMaxAge method in the RemoteRecordingStream class. The check was accidentally added when the class was introduced in JDK 16. The specification states that null is accepted (similar to the Recording class). Max age is by default null, but can be set to another duration, for example Duration.ofHours(1), but not set back to null without this change. 
> 
> Testing: jdk/jdk/jfr
> 
> Thanks
> Erik

Erik Gahlin has updated the pull request incrementally with one additional commit since the last revision:

  Update test

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/12886/files
  - new: https://git.openjdk.org/jdk/pull/12886/files/db1fe6de..093cd00a

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=12886&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=12886&range=00-01

  Stats: 7 lines in 1 file changed: 0 ins; 4 del; 3 mod
  Patch: https://git.openjdk.org/jdk/pull/12886.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/12886/head:pull/12886

PR: https://git.openjdk.org/jdk/pull/12886


More information about the hotspot-jfr-dev mailing list