RFR: 8303681: JFR: RemoteRecordingStream::setMaxAge() should accept null [v2]

Markus Grönlund mgronlun at openjdk.org
Tue Mar 7 13:47:40 UTC 2023


On Mon, 6 Mar 2023 19:42:09 GMT, Erik Gahlin <egahlin at openjdk.org> wrote:

>> Could I have a review of a PR that removes an Objects.requireNonNull from the setMaxAge method in the RemoteRecordingStream class. The check was accidentally added when the class was introduced in JDK 16. The specification states that null is accepted (similar to the Recording class). Max age is by default null, but can be set to another duration, for example Duration.ofHours(1), but not set back to null without this change. 
>> 
>> Testing: jdk/jdk/jfr
>> 
>> Thanks
>> Erik
>
> Erik Gahlin has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update test

Marked as reviewed by mgronlun (Reviewer).

-------------

PR: https://git.openjdk.org/jdk/pull/12886


More information about the hotspot-jfr-dev mailing list