Integrated: 8303681: JFR: RemoteRecordingStream::setMaxAge() should accept null
Erik Gahlin
egahlin at openjdk.org
Tue Mar 7 22:36:26 UTC 2023
On Mon, 6 Mar 2023 19:02:12 GMT, Erik Gahlin <egahlin at openjdk.org> wrote:
> Could I have a review of a PR that removes an Objects.requireNonNull from the setMaxAge method in the RemoteRecordingStream class. The check was accidentally added when the class was introduced in JDK 16. The specification states that null is accepted (similar to the Recording class). Max age is by default null, but can be set to another duration, for example Duration.ofHours(1), but not set back to null without this change.
>
> Testing: jdk/jdk/jfr
>
> Thanks
> Erik
This pull request has now been integrated.
Changeset: 32f4d8b5
Author: Erik Gahlin <egahlin at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/32f4d8b5eaf8c5fa5da745bc1348f513e2ffe3d3
Stats: 11 lines in 3 files changed: 2 ins; 5 del; 4 mod
8303681: JFR: RemoteRecordingStream::setMaxAge() should accept null
Reviewed-by: mgronlun
-------------
PR: https://git.openjdk.org/jdk/pull/12886
More information about the hotspot-jfr-dev
mailing list