RFR: 8317562: [JFR] Compilation queue statistics

[Cesar Soares Lucas]

On Tue, 17 Oct 2023 00:35:54 GMT, Mat Carter <macarte at openjdk.org> wrote:

> Adding a new periodic jfr event to monitor and output statistics for the compiler queues.  You will see one event per compiler queue (c1 and c2)
> 
> Passes tier1 on linux (x86) and mac (aarch64)

Some quick comments.

src/hotspot/share/compiler/compileBroker.hpp line 91:

> 89: 
> 90:   int _size;
> 91:   int _total_added;

Can total be negative?

src/hotspot/share/jfr/periodic/jfrCompilerQueueUtilization.cpp line 55:

> 53:   return ((current - old) * NANOSECS_PER_SEC) / interval.nanoseconds();
> 54: }
> 55: 

NIT: Too many new lines?

src/hotspot/share/jfr/periodic/jfrCompilerQueueUtilization.cpp line 67:

> 65:   const JfrTickspan interval = cur_time - last_sample_instant;
> 66:   for(int i = 0; i < num_compiler_queues; i ++)
> 67:   {

I think this doesn't follow the coding style. See document in "/doc/" folder in the repository.

test/jdk/jdk/jfr/event/compiler/TestCompilerQueueUtilization.java line 36:

> 34:  * @test
> 35:  * @key jfr
> 36:  * @requires vm.hasJFR

Does it need C1 and/or C2?

-------------

PR Review: https://git.openjdk.org/jdk/pull/16211#pullrequestreview-1682911744
PR Review Comment: https://git.openjdk.org/jdk/pull/16211#discussion_r1362487113
PR Review Comment: https://git.openjdk.org/jdk/pull/16211#discussion_r1362485381
PR Review Comment: https://git.openjdk.org/jdk/pull/16211#discussion_r1362486361
PR Review Comment: https://git.openjdk.org/jdk/pull/16211#discussion_r1362480494