RFR: 8317562: [JFR] Compilation queue statistics
Mat Carter
macarte at openjdk.org
Wed Oct 18 15:28:24 UTC 2023
On Tue, 17 Oct 2023 01:06:29 GMT, Martijn Verburg <karianna at openjdk.org> wrote:
>> Adding a new periodic jfr event to monitor and output statistics for the compiler queues. You will see one event per compiler queue (c1 and c2)
>>
>> Passes tier1 on linux (x86) and mac (aarch64)
>
> src/hotspot/share/jfr/periodic/jfrCompilerQueueUtilization.cpp line 55:
>
>> 53: static JfrTicks last_sample_instant;
>> 54: const JfrTickspan interval = cur_time - last_sample_instant;
>> 55: for(int i = 0; i < 2; i ++)
>
> 2 is a magic number, maybe a comment above the for declartion explaining why?
Thanks for the feedback, made this clearer
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16211#discussion_r1362382032
More information about the hotspot-jfr-dev
mailing list