RFR: 8317562: [JFR] Compilation queue statistics [v2]
Mat Carter
macarte at openjdk.org
Sat Oct 28 01:52:08 UTC 2023
On Fri, 20 Oct 2023 04:55:24 GMT, Erik Gahlin <egahlin at openjdk.org> wrote:
>> Mat Carter has updated the pull request incrementally with one additional commit since the last revision:
>>
>> fixed return type and changed NULL to nullptr
>
> src/hotspot/share/jfr/metadata/metadata.xml line 857:
>
>> 855: <Field type="long" contentType="count" name="size" label="Size" description="Current queue size"/>
>> 856: <Field type="long" contentType="count" name="peak" label="Peak Size" description="Peak queue size"/>
>> 857: <Field type="long" contentType="count" name="added" label="Added" description="Added requests"/>
>
> There is no contentType called count. Please remove.
>
> No need to use a description, if it's just a repetition of the name.
-removed contenttType="count"
-removed superfluous descriptions
> test/jdk/jdk/jfr/event/compiler/TestCompilerQueueUtilization.java line 2:
>
>> 1: /*
>> 2: * Copyright (c) 2013, 2023, Oracle and/or its affiliates. All rights reserved.
>
> Why copyright 2013, the file is new.
copy paste mistake (fixed)
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16211#discussion_r1375145353
PR Review Comment: https://git.openjdk.org/jdk/pull/16211#discussion_r1375145237
More information about the hotspot-jfr-dev
mailing list