RFR: 8317562: [JFR] Compilation queue statistics [v2]

[Erik Gahlin]

On Wed, 18 Oct 2023 18:11:45 GMT, Mat Carter <macarte at openjdk.org> wrote:

>> Adding a new periodic jfr event to monitor and output statistics for the compiler queues.  You will see one event per compiler queue (c1 and c2)
>> 
>> Passes tier1 on linux (x86) and mac (aarch64)
>
> Mat Carter has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fixed return type and changed NULL to nullptr

src/hotspot/share/jfr/metadata/metadata.xml line 857:

> 855:     <Field type="long" contentType="count" name="size" label="Size" description="Current queue size"/>
> 856:     <Field type="long" contentType="count" name="peak" label="Peak Size" description="Peak queue size"/>
> 857:     <Field type="long" contentType="count" name="added" label="Added" description="Added requests"/>

There is no contentType called count. Please remove.

No need to use a description, if it's just a repetition of the name.

test/jdk/jdk/jfr/event/compiler/TestCompilerQueueUtilization.java line 2:

> 1: /*
> 2:  * Copyright (c) 2013, 2023, Oracle and/or its affiliates. All rights reserved.

Why copyright 2013, the file is new.

test/jdk/jdk/jfr/event/compiler/TestCompilerQueueUtilization.java line 45:

> 43: 
> 44:     public static void main(String[] args) throws Exception {
> 45:         Recording recording = new Recording();

Use try-with-resources

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16211#discussion_r1366464679
PR Review Comment: https://git.openjdk.org/jdk/pull/16211#discussion_r1366477481
PR Review Comment: https://git.openjdk.org/jdk/pull/16211#discussion_r1366464793