RFR: 8317562: [JFR] Compilation queue statistics [v2]

Mat Carter macarte at openjdk.org
Sat Oct 28 01:57:37 UTC 2023


On Fri, 27 Oct 2023 21:53:38 GMT, Brian Stafford <bstafford at openjdk.org> wrote:

>> Mat Carter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fixed return type and changed NULL to nullptr
>
> test/jdk/jdk/jfr/event/compiler/TestCompilerQueueUtilization.java line 48:
> 
>> 46:         recording.enable(EVENT_NAME);
>> 47:         recording.start();
>> 48:         recording.stop();
> 
> Would it be useful to delay the recording stop in order to give more of an opportunity for compiler events to occur?

I've followed the pattern for other events that output periodically and don't want to add unnecessary time as that will cause the test suite to take longer, the test will fail if there are no events due to the line 'Events.hasEvents(events)'

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16211#discussion_r1375145759


More information about the hotspot-jfr-dev mailing list