RFR: 8336316: JFR: Use SettingControl::getValue() instead of setValue() for ActiveSetting event
Erik Gahlin
egahlin at openjdk.org
Mon Jul 22 09:53:59 UTC 2024
Could I have a review of a change that makes the ActiveSetting event act differently when an invalid value is specified.
Previously the last set value was used, but now the result of getValue() is returned. In case Control::getLastValue() returns null, the default value is used. Benefit of this change is to make it easier to diagnose setting related issues. The event will reports the actual state of the event setting, not what happens to have been specified.
Testing: jdk/jdk/jfr
Thanks
Erik
-------------
Commit messages:
- Initial
Changes: https://git.openjdk.org/jdk/pull/20172/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=20172&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8336316
Stats: 7 lines in 1 file changed: 3 ins; 1 del; 3 mod
Patch: https://git.openjdk.org/jdk/pull/20172.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/20172/head:pull/20172
PR: https://git.openjdk.org/jdk/pull/20172
More information about the hotspot-jfr-dev
mailing list